Created on 2020-09-04 by the reprex package (v0.3.0.9001)
Here in dials, this PR currently does not issue a warning that fewer rows are returned that were specified (this is different behavior than in tune). I noticed that this is the existing behavior for grid_regular() so I matched it:
This also means that if n is larger than the range of the integers, a smaller set will be generated.
We can definitely generate a warning, but then folks will get a warning in one situation and not in others. I do think we should add something in the documentation, probably to the size argument. Sound good?
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.
This PR closes #133 and is related to tidymodels/tune#270.
Created on 2020-09-04 by the reprex package (v0.3.0.9001)
Here in dials, this PR currently does not issue a warning that fewer rows are returned that were specified (this is different behavior than in tune). I noticed that this is the existing behavior for
grid_regular()
so I matched it:We can definitely generate a warning, but then folks will get a warning in one situation and not in others. I do think we should add something in the documentation, probably to the
size
argument. Sound good?