tidymodels / dials

Tools for creating tuning parameter values
https://dials.tidymodels.org/
Other
113 stars 27 forks source link

sample_size() #175

Closed Steviey closed 2 years ago

Steviey commented 3 years ago

_dials 0.0.9, modeltime latest, model: prophet_boost_

Fix: https://github.com/tidymodels/dials/issues/111 seems not to include finalizing the whole enchilada at once...

finalParams <- modelObj %>% parameters() %>% 
                    finalize(x=trainPart) 

I'll do this (looks ugly):

finalParams<-finalParams %>% update(sample_size = sample_prop(c(0.4, 0.9)))

cu

juliasilge commented 3 years ago

Can you create a reprex (a minimal reproducible example) to show what kind of problem you are having with dials::sample_size()? The goal of a reprex is to make it easier for us to recreate your problem so that we can understand it and/or fix it.

If you've never heard of a reprex before, you may want to start with the tidyverse.org help page. You may already have reprex installed (it comes with the tidyverse package), but if not you can install it with:

install.packages("reprex")

Thanks! 🙌

github-actions[bot] commented 2 years ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.