Add xgboost specific tuning parameters

tidymodels / dials

Tools for creating tuning parameter values

https://dials.tidymodels.org/

Other

113 stars 27 forks source link

Add xgboost specific tuning parameters #179

Closed joeycouse closed 3 years ago

joeycouse commented 3 years ago

This PR adds two engine specific tuning parameters for the xgboost engine. I'm new at this so I expect there will need to be some changes. There probably has to be something on the parsnip side to rename the args to the xgboost params lambda and alpha. Let me know and I'll try my best!

joeycouse commented 3 years ago

Oh btw, I set the range of the penalties to go up to 10 instead of just 1. My thought was since lambda is already 1 by default we should check above and below the default value.

topepo commented 3 years ago

Looks great. Thanks for doing this.

Can you add some tests to test_params.R? They are pretty simple (grep on "penalty") and do something similar.

joeycouse commented 3 years ago

Closed this on accident!

github-actions[bot] commented 3 years ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.