Use `pillar::type_sum()` rather than `dplyr::type_sum()`

tidymodels / dials

Tools for creating tuning parameter values

https://dials.tidymodels.org/

Other

111 stars 26 forks source link

Use `pillar::type_sum()` rather than `dplyr::type_sum()` #234

Closed DavisVaughan closed 2 years ago

DavisVaughan commented 2 years ago

We'd like to eventually remove dplyr::type_sum(), which just reexports pillar::type_sum(). To do this, we need to switch over to using the pillar version.

We import type_sum() from tibble and dplyr here: https://github.com/tidymodels/dials/blob/252f8f61476815c1f2b33965f0f300d68de722cf/R/dials-package.R#L40-L46

And use the dplyr:: namespaced version here https://github.com/tidymodels/dials/blob/6e63018d797e4b995919cc83627879be0305ebd0/R/parameters.R#L160

hfrick commented 2 years ago

closed in https://github.com/tidymodels/dials/pull/236

github-actions[bot] commented 2 years ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.