search

tidymodels / dials

Tools for creating tuning parameter values
https://dials.tidymodels.org/
Other
113 stars 27 forks source link

Deprecate `default` argument #241

Closed hfrick closed 2 years ago

hfrick commented 2 years ago

This PR removes the default argument to the constructors new_quant_param() and new_qual_param(). Closes #229 and closes #153.

The default value was used in a single place: when generating a sequence of parameter values of length 1 via value_seq(n = 1). This PR removes the special behaviour for n = 1 in value_seq() and removes all the default values for the exported parameter functions like Laplace().

The revdep checks came back clean.

hfrick commented 2 years ago

@DavisVaughan I've addressed the comments from our review session 🙌

@topepo Max, could you also have a look at this since the PR removes the default values also for the exported parameter objects?

github-actions[bot] commented 2 years ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.