Deprecate grid methods for `workflow` objects

tidymodels / dials

Tools for creating tuning parameter values

https://dials.tidymodels.org/

Other

114 stars 27 forks source link

Deprecate grid methods for `workflow` objects #299

Closed hfrick closed 1 year ago

hfrick commented 1 year ago

Those are:

[ ] grid_regular.workflow()
[ ] grid_random.workflow()
[ ] grid_max_entropy.workflow()
[ ] grid_latin_hypercube.workflow()

hfrick commented 1 year ago

They are currently broken because they use parameters() to extract the parameter set from a workflow and that functionality has already been moved from dials to workflows.

We don't seem to be using them in tune (but rather extract the parameter set first, then call grid_*() on that), e.g. in check_grid().

Rev dep checks for simply removing them also don't show any problems (319bacf4-4ef7-473e-9e5b-92dcea3c39ee).

I'm gonna go ahead and deprecate those instead of moving them.

github-actions[bot] commented 1 year ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.