search

tidymodels / dials

Tools for creating tuning parameter values
https://dials.tidymodels.org/
Other
114 stars 27 forks source link

Massively reduce flakiness #309

Closed MichaelChirico closed 1 year ago

MichaelChirico commented 1 year ago

Closes #308.

Also switch to expect_setequal() for readability. Note that recent {testthat} makes expect_setequal() more attractive:

https://github.com/r-lib/testthat/issues/1657

hfrick commented 1 year ago

Thank you but closing since it's outdated, see also https://github.com/tidymodels/dials/issues/308#issuecomment-1754869943

MichaelChirico commented 1 year ago

Oh, @hfrick, actually this PR changed a different test:

https://github.com/tidymodels/dials/blob/55763e0cbd49a16a3f5a532dc92b9069258d54e7/tests/testthat/test-aaa_values.R#L174-L178

Should I change it to use the same "test for subset" approach?

hfrick commented 1 year ago

Oh, good catch! Yeah, would you make a fresh PR and change both of those expectations to that approach? If you want to go for using expect_in(), that would be a nice upgrade.

github-actions[bot] commented 1 year ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.