search

tidymodels / dials

Tools for creating tuning parameter values
https://dials.tidymodels.org/
Other
113 stars 27 forks source link

Update param_max_tokens upper bound #72

Closed EmilHvitfeldt closed 4 years ago

EmilHvitfeldt commented 5 years ago

We are going to overshoot too often with 10^5. With diminishing returns I'll suggest having 1000 for the upper bound as a default instead

codecov-io commented 4 years ago

Codecov Report

Merging #72 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   84.91%   84.91%           
=======================================
  Files          46       46           
  Lines        1180     1180           
=======================================
  Hits         1002     1002           
  Misses        178      178
Impacted Files Coverage Δ
R/param_max_tokens.R 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d44930e...c1c1537. Read the comment docs.

github-actions[bot] commented 3 years ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.