search

tidymodels / discrim

Wrappers for discriminant analysis and naive Bayes models for use with the parsnip package
https://discrim.tidymodels.org
Other
28 stars 3 forks source link

Adding fastNaiveBayes as engine to naive_bayes() #5

Closed EmilHvitfeldt closed 4 years ago

EmilHvitfeldt commented 4 years ago

Would you be open for a PR adding https://github.com/mskogholt/fastNaiveBayes as an engine to naive_bayes()?

topepo commented 4 years ago

I'm not a fan of this. It is only fast because it pushes the work on the user. I think that we would end up fielding issues in our repos because it deliberately operates differently than most packages.

EmilHvitfeldt commented 4 years ago

Alright, sounds reasonable.

EmilHvitfeldt commented 4 years ago

what about naive_bayes() from the naivebayes package? That one was available in caret.

https://github.com/majkamichal/naivebayes

topepo commented 4 years ago

That looks fine. Should I or do you want to take a shot at it?

EmilHvitfeldt commented 4 years ago

I can take a shot at it

github-actions[bot] commented 3 years ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.