search

tidymodels / discrim

Wrappers for discriminant analysis and naive Bayes models for use with the parsnip package
https://discrim.tidymodels.org
Other
28 stars 3 forks source link

Add naivebayes engine to naive_Bayes #6

Closed EmilHvitfeldt closed 4 years ago

EmilHvitfeldt commented 4 years ago

To close #5.

@topepo how do you want me to add tests? Should they be in a new file?

topepo commented 4 years ago

I would add tests that show the the correct predictions are made (compared to a model created manually).

I'm starting to thing that the model definition code should be inside nocov blocks since they get tested but the coverage software doesn't attribute functional tests to this code.

Also please update NEWS and pkgdown too.

EmilHvitfeldt commented 4 years ago

I added the tests and should be ready. There wasn't a news.md file so I created one.

pkgdown hasn't been set up beyond the basics, so I feel it might be outside the scope of this PR to fix that

github-actions[bot] commented 3 years ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.