search

tidymodels / extratests

Integration and other testing for tidymodels
Other
20 stars 1 forks source link

Add test on logging for racing with survival models #138

Closed hfrick closed 10 months ago

hfrick commented 11 months ago

The issue mentioned in this comment has been closed https://github.com/tidymodels/finetune/issues/81

https://github.com/tidymodels/extratests/blob/15314420e460a9e05ce81a74cfd411bf482c6fde/tests/testthat/test-survival-tune-race.R#L404-L406

topepo commented 10 months ago

Closed by #158

Specifically these lines

hfrick commented 9 months ago

I read that code comment as "check that the evaluation time is mentioned" whereas the test checks that the metric is mentioned. Shall we reopen this issue or is that a misunderstanding?

hfrick commented 9 months ago

Keeping this closed, Max produced this as a receipt 😛 https://github.com/tidymodels/extratests/blob/683ec31268d2af45634ea9779835ee0fa09e7ba6/tests/testthat/test-survival-tune_race_anova.R#L440