Closed hfrick closed 8 months ago
It'd be nice if we could use tune::check_metric_in_tune_results()
right before that warning is raised, but the check_metric_in_tune_results()
function isn't exported currently. Should we export it or is it trivial enough to copy?
Max gave a thumbs-up on exporting. On odbc today but will spend some time on this tomorrow if it hasn't been tackled by another person by then. :)
Following on from https://github.com/tidymodels/extratests/pull/156/files/c147241a882641e12e8c0b89cfdd7aa64817aed4#r1439642019
show_best.tune_race()
should only error, not warn and then error, if a metric is used that is not included in thetune_results
object.This will also require updating the corresponding tests in extratests.
Created on 2024-01-05 with reprex v2.0.2