search

tidymodels / hardhat

Construct Modeling Packages
https://hardhat.tidymodels.org
Other
101 stars 16 forks source link

novel levels (again) #102

Closed topepo closed 4 years ago

topepo commented 5 years ago

It would be good to have an option to skip the novel levels check. For applicable, we want to test to see if there are new points that are different than the others and this check coerces to NA in those cases (and we lose all subsequent calculations to propagated NA values).

Maybe only for the recipe case (since we have step_novel())?

@marlycormar

DavisVaughan commented 4 years ago

Should a user only be allowed to skip the check for predictors? If we let a user say:

default_formula_blueprint(allow_novel_levels = TRUE)

Would that affect novel levels in the outcomes as well? Is it ever ok to allow novel outcome levels? It seems like the answer would be no.

github-actions[bot] commented 3 years ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.