added a one_hot encoding argument

tidymodels / hardhat

Construct Modeling Packages

https://hardhat.tidymodels.org

Other

101 stars 16 forks source link

added a one_hot encoding argument #140

Closed topepo closed 4 years ago

topepo commented 4 years ago

Phase 1 of a fix for tidymodels/workflows#41

Please review current changes.

An error is throw for any settings with indicators = FALSE and one_hot = TRUE.

Still to-do: test cases and argument checking when older hardhat objects are passed to forge()

Question: remove_formula_intercept() is functionally independent of the intercept argument. I can take that out but I'm not sure if it will break backwards compatibility.

topepo commented 4 years ago

This PR also changes the pkgdown url to hardhat.tidymodels.org and the repo settings will need to be changed after merging.

juliasilge commented 4 years ago

I used this in a lot of tests, examples, etc when working in the workflows PR, and I feel pretty confident it is working as intended.

github-actions[bot] commented 3 years ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.