search

tidymodels / hardhat

Construct Modeling Packages
https://hardhat.tidymodels.org
Other
101 stars 16 forks source link

more specific name for get_predict_function #152

Closed topepo closed 3 years ago

topepo commented 3 years ago

If there are multiple modeling functions in a package created by hardhat, the user has to remember to rename get_predict_function() so that there are not conflicts. Most of the other functions have the model name in them.

topepo commented 3 years ago

Maybe the same for others too, such as valid_predict_types()

DavisVaughan commented 3 years ago

Those look to be the only two that dont have the model name in them. I think that change makes sense 👍

get_{{model}}_predict_function()

valid_{{model}}_predict_types()

github-actions[bot] commented 3 years ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.