Detect `:` more robustly in `mold()`

tidymodels / hardhat

Construct Modeling Packages

https://hardhat.tidymodels.org

Other

101 stars 16 forks source link

Detect `:` more robustly in `mold()` #175

Closed DavisVaughan closed 2 years ago

DavisVaughan commented 2 years ago

Closes #174 Closes #173

Hopefully this is a more robust solution than using grepl(). The column names of the factor matrix were all originally expressions, so re-parsing them should always work. And I'm fairly certain the edge cases of expr_contains() are handled nicely.

github-actions[bot] commented 2 years ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.