search

tidymodels / hardhat

Construct Modeling Packages
https://hardhat.tidymodels.org
Other
101 stars 15 forks source link

Pass through strings_as_factors arg #212

Closed jonthegeek closed 1 year ago

jonthegeek commented 2 years ago

I'd like to specify that predictors should be string for a BERT-based neural net, but mold doesn't pass that argument through to prep.

DavisVaughan commented 2 years ago

This seemed reasonable to me because we already give people a way to tweak the fresh argument to prep(), so essentially it would just be exposing one more prep() argument in the recipe blueprint https://github.com/tidymodels/hardhat/blob/1e43f0e1ee89b9bd0a4bc9bb138a0ef11ff3e422/R/blueprint-recipe-default.R#L216

jonthegeek commented 1 year ago

Thanks! I've been meaning to PR this but never got to it, I'm glad you were able to do so!

github-actions[bot] commented 1 year ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.