tidymodels / hardhat

Construct Modeling Packages
https://hardhat.tidymodels.org
Other
101 stars 15 forks source link

Remove unnecessary `as_tibble` calls #225

Closed frank113 closed 1 year ago

frank113 commented 1 year ago

This pull request addresses issue #222 by removing unnecessary as_tibble calls.

Changes made:

as_tibble occurs 7 times in the code as of the time of this comment at commit c2c896cf1141883533ce5d4ad37e80fd6284c92a. To remove redundant calls we will examine the following uses:

  1. model_frame in R/model-frame.R:
    • The data parameter is passed through the check_is_data_lake. For check_is_data_like to succeed the data parameter must be either a data.frame or matrix
    • I added tests in test-util.R that confirms the behavior of
frank113 commented 1 year ago

Did not mean to open, will re-open when work is completed.

github-actions[bot] commented 1 year ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.