Closed frank113 closed 1 year ago
Did not mean to open, will re-open when work is completed.
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.
This pull request addresses issue #222 by removing unnecessary
as_tibble
calls.Changes made:
check_is_data_like
in newly-createdtest-util.R
to validate behavioras_tibble
call inmodel_frame
as it repeats logic performed incheck_is_data_like
that coerces the first parameter to a tibble.as_tibble
call incheck_is_data_like
to ensure that thedata
field ofmodel_frame
will always be a tibble.model_frame
to ensure that thedata
field will always be a tibbleas_tibble
occurs 7 times in the code as of the time of this comment at commit c2c896cf1141883533ce5d4ad37e80fd6284c92a. To remove redundant calls we will examine the following uses:model_frame
inR/model-frame.R
:data
parameter is passed through thecheck_is_data_lake
. Forcheck_is_data_like
to succeed thedata
parameter must be either adata.frame
ormatrix
test-util.R
that confirms the behavior of