Do we really need forge_impl()?

tidymodels / hardhat

Construct Modeling Packages

https://hardhat.tidymodels.org

Other

103 stars 17 forks source link

Do we really need forge_impl()? #66

Closed DavisVaughan closed 5 years ago

DavisVaughan commented 5 years ago

It would get around the non-exported generic extensibility problem if we just moved it into forge()

Also, does forge() need to be generic? Error catching should be done by $clean()

DavisVaughan commented 5 years ago

But mold() would still have this problem. Maybe export both under a different name?

github-actions[bot] commented 3 years ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.