search

tidymodels / hardhat

Construct Modeling Packages
https://hardhat.tidymodels.org
Other
101 stars 16 forks source link

model_matrix() argument order #69

Closed DavisVaughan closed 5 years ago

DavisVaughan commented 5 years ago

data should come before terms. This is also consistent with model_offset()

DavisVaughan commented 5 years ago

Same for model_frame()

DavisVaughan commented 5 years ago

Makes more sense to just flip the order of model_offset(). To be consistent with actual modeling functions like lm(), it makes sense for the formula to come first

github-actions[bot] commented 3 years ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.