tidymodels / infer

An R package for tidyverse-friendly statistical inference
https://infer.tidymodels.org
Other
724 stars 80 forks source link

Hex logo missing on package homepage #516

Closed mine-cetinkaya-rundel closed 10 months ago

mine-cetinkaya-rundel commented 10 months ago

There's a broken image link.

Screenshot 2023-11-27 at 10 23 40 AM

simonpcouch commented 10 months ago

Thank you. :) That broken URL has been fixed on main, but it looks like the site is now once again rendering from the v1.0.0 site.😵‍💫

Looping @andrewpbray in here:

I've kept the docs/ folder around since we transitioned to infer.tidymodels.org from infer.netlify.app just so that the legacy site would stay up. Right now, the v1.0.0 docs (which I thought were being deployed from the gh-pages branch) are live on infer.tidymodels.org, and the v1.0.1 docs are live at infer.netlify.app (which I thought was being deployed from /docs on main through your Netlify).

My first step in debugging this would be to get rid of that /docs folder, as we don't use it elsewhere in the tidymodels and the CNAME seems to be tracking it, but I don't want to unintentionally take that legacy site down. In the Netlify UI, would it be possible to deploy from the gh-pages branch rather than the docs folder? In Build & Deploy > Build settings, you'd remove the docs "Publish directory", and in Build & Deploy > Branches and deploy contexts, you'd change "Production branch" to gh-pages. (Or just redirect the site to infer.tidymodels.org, though I'm not sure on the specifics of that.)

andrewpbray commented 10 months ago

@mine-cetinkaya-rundel Thanks for bringing this up! I've been wondering about that missing image for awhile now.

Here's what the netlify config looked like when I logged in just now:

Screen Shot 2023-12-02 at 9 43 25 AM Screen Shot 2023-12-02 at 9 43 17 AM

But then there's this:

Screen Shot 2023-12-02 at 9 44 01 AM

And the error message:

  UNSUPPORTED BUILD IMAGE

  The build image for this site uses Ubuntu 14.04 Trusty Tahr, which is no longer supported.

  To enable builds for this site, select a later build image at the following link:
  https://app.netlify.com/sites/infer/settings/deploys#build-image-selection

  For more details, visit the build image migration guide:
  https://answers.netlify.com/t/end-of-support-for-trusty-build-image-everything-you-need-to-know/39004
  ---------------------------------------------------------------------

The timestamp on those actions correspond to this action on github.com/tidymodels/infer:

https://github.com/tidymodels/infer/actions/runs/6725139929

I don't recall how this was originally set up - any idea what this GitHub pages bot is? I don't see it in the actions stored in the repo.

Hmm... 🤔

Simon, I tried adding you to the team that owns that netlify site but apparently that's not possible on free-tier =/

simonpcouch commented 10 months ago

re:

The timestamp on those actions correspond to this action on github.com/tidymodels/infer

that makes sense! Okay, good to know that the old site looks to gh-pages already. Looks like we just need to debug the 14.04 issue, but otherwise that failure is independent from the issue we're seeing with the production site.

The string "14.04" doesn't appear anywhere in the repo, so I'm tempted to say the issue you're seeing arises from somewhere in the Netlify UI config. The guide linked in your comment points to Site settings > Build & deploy > Continuous Deployment > Build image selection--do you see anything that looks relevant there? The content on gh-pages doesn't need a build command, so I think you can just freely bump that Ubuntu version and the next Actions run will build successfully. You'll get a reply from me within one business day if anything goes awry.😜

I'm going to look into the issues on infer.tidymodels.org now.

andrewpbray commented 10 months ago

Right-o, that's the ticket!

Before:

Screen Shot 2023-12-05 at 8 10 41 AM

Migration guide link: https://answers.netlify.com/t/please-read-end-of-support-for-trusty-build-image-everything-you-need-to-know/39004?_gl=1*10obc5c*_gcl_au*MTk3NDg1MTQxNS4xNzAxNTM4NzQz

And after:

Screen Shot 2023-12-05 at 8 11 35 AM

It looks like this made it deployable:

Screen Shot 2023-12-05 at 8 14 35 AM

But we're still not getting the hex sticker on either site. Hmm...

simonpcouch commented 10 months ago

Awesome. I'll look into tracking down the gh-pages issue, now.

simonpcouch commented 10 months ago

Fixed on infer.tidymodels.org and infer.netlify.app via https://github.com/tidymodels/infer/actions/runs/7103986957. :)

Screenshot 2023-12-05 at 11 58 16 AM

andrewpbray commented 10 months ago

Incidentally, here's what my office table looks like this evening.

IMG_2095

The students are big fans of the stickers.

simonpcouch commented 10 months ago

Ha, the Oregon license plate stickers! My personal favorite.🤩

github-actions[bot] commented 9 months ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.