search

tidymodels / infer

An R package for tidyverse-friendly statistical inference
https://infer.tidymodels.org
Other
726 stars 80 forks source link

address `fit.infer()` + `visualize()` snap failures #545

Closed simonpcouch closed 2 months ago

simonpcouch commented 2 months ago

Seeing snap failures for visualize() on fit.infer() output (first seen in #544 but can also observe on main)—only tests on output from fit(), and all of the output from fit(). No changes to vdiffr or the graphics engine that would explain the new failures, and only on macOS, so I'm a bit confused as to what the root cause may be, but the snaps are visually indistinguishable to me.

I'm guessing macOS will pass but other check systems will fail, in which case we'll need to make snap variants depending on OS.

github-actions[bot] commented 1 month ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.