tidymodels / multilevelmod

Parsnip wrappers for mixed-level and hierarchical models
https://multilevelmod.tidymodels.org/
Other
74 stars 3 forks source link

Gee models #7

Closed shah-in-boots closed 3 years ago

shah-in-boots commented 3 years ago

This should allow for linear and logistic models to be run using the original gee::gee() function. I've added appropriate tests as well.

I haven't yet put together poisson, but wanted to see if this seemed like a reasonable addition thus far. Also, not sure if poissonreg would be a better home for that. When we're discussion models based on distribution, they really start melting together at the edges.

topepo commented 3 years ago

Sorry for the delay. It looks great. One request, please add gee to Suggests.

topepo commented 3 years ago

Also, yes, an engine for Poisson models would be better in poissonreg. That shouldn't be too bad since gee_fit() is exported here.

topepo commented 3 years ago

(For posterity) There are some significant differences in how gee() operates and most other modeling functions, especially glm(). None of these are documented in ?gee:

topepo commented 3 years ago

The GH actions failures are due to the nloptr package failing to build from source. I'll merge.

Thanks for the help @asshah4. If you add another PR to poissonreg, it should be pretty similar to the linear regression work here.

github-actions[bot] commented 3 years ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.