Closed EmilHvitfeldt closed 2 months ago
This PR converts existing checks to {cli}, expanded checking will be tracked with https://github.com/tidymodels/parsnip/issues/1095
Todo: make sure we allow zero length input in input checking as per https://github.com/tidymodels/parsnip/issues/1099
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.
Ref: https://github.com/tidymodels/parsnip/issues/1081
Now the call are being passed around, such as it is being emitted from
fit()
which feels appropriate. I wonder is there is a way to signal the model as well? so instead of sayingError in fit():
it says something likeError in fit() for discrim_linear():
or something to that liking. It would be nice for workflowsetsAlso, I didn't detect any tests 😬 so I'll add those as well
Extension packages:
Empty tests
Some of the tests are left intentionally empty, this is either because there is a placeholder
check_args()
method with no checking, or no method at all. All missing methods will be handled by https://github.com/tidymodels/parsnip/issues/1094