tidymodels / parsnip

A tidy unified interface to models
https://parsnip.tidymodels.org
Other
599 stars 89 forks source link

revisiting `tunable()` for model specifications #1105

Open simonpcouch opened 7 months ago

simonpcouch commented 7 months ago

Going ahead and PRing now to introduce tests and run GHA with them so I can demonstrate they still pass once I make some upcoming changes.

EDIT: Closes #1104.

simonpcouch commented 7 months ago

extract_parameter_set_dials() tests fail because they expect anything marked with tune() to appear in tunable() output.

Next steps would be to:

If those changes restore previous extract_parameter_set_dials.model_spec() behavior, the next step would be to revise and test tunable() methods in parsnip extensions. :)