tidymodels / parsnip

A tidy unified interface to models
https://parsnip.tidymodels.org
Other
564 stars 78 forks source link

`Timing stopped at` messages when engine fit fails #1109

Closed simonpcouch closed 1 month ago

simonpcouch commented 2 months ago

Intentionally introducing a failure:

# with extract_fit_time():
# pak::pak("tidymodels/parsnip@fd5124c")

library(parsnip)
library(modeldata)

boost_tree(mtry = tune::tune()) %>%
  set_mode("regression") %>%
  fit(bill_length_mm ~ ., data = penguins)
#> Error in min(denom, x): invalid 'type' (language) of argument
#> Timing stopped at: 0.002 0.001 0.003

Created on 2024-04-09 with reprex v2.1.0

Before #853:

# with CRAN:
library(parsnip)
library(modeldata)

boost_tree(mtry = tune::tune()) %>%
  set_mode("regression") %>%
  fit(bill_length_mm ~ ., data = penguins)
#> Error in min(denom, x): invalid 'type' (language) of argument

Created on 2024-04-09 with reprex v2.1.0

This showed up in snaps on bonsai.

github-actions[bot] commented 1 month ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.