search

tidymodels / parsnip

A tidy unified interface to models
https://parsnip.tidymodels.org
Other
590 stars 88 forks source link

Use cli errors in `R/predict_class.R`, `R/predict_classprob.R`, `R/predict_numeric.R`, and `R/predict_time.R` #1141

Closed EmilHvitfeldt closed 1 month ago

EmilHvitfeldt commented 2 months ago

Most or all errors thrown in this package are made via rlang::abort(). We are transitioning to cli::cli_abort() to make use of the richer styling options for errors via cli (which calls rlang under the hood). This issue is part of https://github.com/tidymodels/parsnip/issues/1081

It is often sufficient to search for and replace the rlang version with the cli version together with adding a little bit of styling.

Some examples of the styling possibilities are in the general introduction under the section of Inline text formatting. More details on inline formatting and pluralization.

One aspect to watch out for when transitioning from rlang::abort() to cli::cli_abort() are messages pre-assembled from user input as described here.

499 can serve as an example.

simonpcouch commented 1 month ago

Closed in #1154!

github-actions[bot] commented 2 weeks ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.