Closed topepo closed 1 year ago
error if grouped data.frame passed to functions. Refer to .by
argument
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.
There are
group
arguments to thecal_plot_*
andcal_estimate_*
functions. There are overlaping issues regarding groups (#79, #92,#98, #100). Looking at these, we should have a more systematic approach rather than multiple refactors that might overlap.I think that we should only enable group-by processing when the input is a data frame (and not an object generated by the tune package). We should default to using .config for tune objects when there are multiple configurations (and
NULL
otherwise).Change 1
In the many functions it is set in both the S3 generic and also in an internal helper called
tune_results_args()
.group
argument and setgroup
to.config
if there are multiple configurations.The logic for
group
should not be in multiple places so it should be taken out oftune_results_args()
.Change 2
The user-facing argument should be called
.by
to be consistent with new dplyr syntax. It should only accept a single, categorical column in the data.