Use `expect_snapshot()` more

tidymodels / recipes

Pipeable steps for feature engineering and data preprocessing to prepare for modeling

https://recipes.tidymodels.org

Other

571 stars 113 forks source link

Use `expect_snapshot()` more #1375

Closed EmilHvitfeldt closed 1 month ago

EmilHvitfeldt commented 2 months ago

to close https://github.com/tidymodels/recipes/issues/1363

This PR:

switched from expect_warning() and expect_message() to expect_snapshot()
removed classed expect_error() and switched to expect_snapshot(error = TRUE)
Switched from expect_error(..., NA) to expect_no_error(). Can't do expect_no_condition() due to dplyr_regroup signal
Switched rest of expect_error() to expect_snapshot(error = TRUE)

No bad snapshots were found in the switch 🙌

github-actions[bot] commented 1 month ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.