Paste the outputs of deparse() to guarantee a length-1 vector (Fixes #459)

tidymodels / rsample

Classes and functions to create and summarize resampling objects

https://rsample.tidymodels.org

Other

341 stars 66 forks source link

Paste the outputs of deparse() to guarantee a length-1 vector (Fixes #459) #461

Closed mikemahoney218 closed 1 year ago

mikemahoney218 commented 1 year ago

This PR fixes #459 by ensuring deparse() generates a length-1 vector. The code to build using_bootstraps is taken from deparse1(), which was added in R 4.0; once rsample drops support for 3.6 it might make sense to change this to deparse1() instead for readability. The new test is taken directly from #459 's excellent reprex.

hfrick commented 1 year ago

Excellent, thank you very much! 🙌

github-actions[bot] commented 1 year ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.