Don't export `.get_split_args()`

tidymodels / rsample

Classes and functions to create and summarize resampling objects

https://rsample.tidymodels.org

Other

341 stars 66 forks source link

Don't export `.get_split_args()` #495

Closed hfrick closed 5 months ago

hfrick commented 6 months ago

until we need to and

Since we were able to make do in https://github.com/tidymodels/tune/pull/894 with that just function, no pressure from me to export or otherwise mobilize further here.

https://github.com/tidymodels/rsample/pull/483#discussion_r1611702826

simonpcouch commented 6 months ago

I did just complicate this story in https://github.com/tidymodels/rsample/pull/489#discussion_r1613507422. Will defer to you here.🤔

hfrick commented 6 months ago

Summary of discussion under https://github.com/tidymodels/rsample/pull/489#discussion_r1613507422 We'll leave this PR open for now and see if we end up using this helper in tune after all. If not, we'll merge this.

simonpcouch commented 5 months ago

tune now does indeed use this helper, so I will go ahead and close.🐬

github-actions[bot] commented 5 months ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.