search

tidymodels / rsample

Classes and functions to create and summarize resampling objects
https://rsample.tidymodels.org
Other
341 stars 66 forks source link

Test error class rather than snapshot for errors from other packages #542

Open hfrick opened 2 months ago

hfrick commented 2 months ago

This looks like we are testing errors from tidyselect in various places. Example: https://github.com/tidymodels/rsample/blob/bdf12e17d0e2f09b7da195fc7110bc1d16d15a22/tests/testthat/_snaps/boot.md?plain=1#L17-L22

If so, we should test the error class rather than the message, like here: https://github.com/tidymodels/rsample/blob/bdf12e17d0e2f09b7da195fc7110bc1d16d15a22/tests/testthat/test-compat-vctrs.R#L67

hfrick commented 2 months ago

link to tidyselect: #413