search

tidymodels / spatialsample

Create and summarize spatial resampling objects 🗺
https://spatialsample.tidymodels.org
Other
71 stars 5 forks source link

Wrap `clustering_cv()` #104

Closed mikemahoney218 closed 1 year ago

mikemahoney218 commented 2 years ago

Feature

Once https://github.com/tidymodels/rsample/pull/352 is merged, it would be nice for spatial_clustering_cv() to become a thin wrapper on top of clustering_cv(), the same way that our vfold functions wrap vfold_cv() with optional buffering.

juliasilge commented 2 years ago

We discussed in our meeting today a plan for:

  1. CRAN release of rsample without the clustering CV change
  2. Merge in clustering CV to rsample
  3. Next CRAN release for rsample a while after that
  4. Make this thin wrapper here in spatialsample

I think this is a great change but I'd prefer to have clustering CV in the development version for a bit before release.

github-actions[bot] commented 1 year ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.