tidymodels / spatialsample

Create and summarize spatial resampling objects 🗺
https://spatialsample.tidymodels.org
Other
71 stars 5 forks source link

Fix CI (fixes #111) #112

Closed mikemahoney218 closed 2 years ago

mikemahoney218 commented 2 years ago

Update to newer Ubuntu runners, new pillar

mikemahoney218 commented 2 years ago

I'm personally very curious if this is going to use the new or old CI configuration... :eyes:

mikemahoney218 commented 2 years ago

...well that's a bigger issue than expected.

mikemahoney218 commented 2 years ago

For what it's worth, the package seems to install fine on my machine (on Ubuntu 22.04), the other Ubuntu jobs seem to be fine, and the other R-CMD-check jobs seem to be fine. So this is either an issue with 20.04 (which I was on when I wrote the C++ bits of package, so that'd be surprising) or the CI environment. I'll dig in later.

mikemahoney218 commented 2 years ago

so rather confusingly, the step that says it fails (spatialsample failing to install) isn't actually the problem

the previous step, installing sf using ubuntugis-unstable system libraries, actually fails but reports a success: https://github.com/tidymodels/spatialsample/runs/8194307701?check_suite_focus=true#step:6:218

That's annoying, but at least gives somewhere to look. Specifically, that points me here: https://www.mail-archive.com/gdal-dev@lists.osgeo.org/msg36151.html

So hopefully installing libspatialite helps.

mikemahoney218 commented 2 years ago

@hfrick We talked about this last month, but I'd rather be safe than sorry: is this the sort of change I can merge without a review? There's no features or behaviors being changed here, just basic maintenance stuff.

hfrick commented 2 years ago

yes, totally! 👍 Please merge the maintenance PRs as you see fit!

github-actions[bot] commented 2 years ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.