tidymodels / tidyclust

A tidy unified interface to clustering models
https://tidyclust.tidymodels.org/
Other
109 stars 17 forks source link

Reverse dependencies issue on CRAN related to ClusterR #186

Closed mlampros closed 5 months ago

mlampros commented 5 months ago

I'm the author of the ClusterR package (which appears in the Suggests of tidyclust) and yesterday I fixed an issue related to the Centroids of the Kmeans_rcpp() function. I submitted today the updated version to CRAN and received a reverse dependencies issue for the tidyclust R package,

package ClusterR_1.3.3.tar.gz has been auto-processed. The auto-check found problems when checking the first order strong reverse dependencies.
Please reply-all and explain: Is this expected or do you need to fix anything in your package? If expected, have all maintainers of affected packages been informed well in advance? Are there false positives in our results?

*** Changes to worse in reverse dependencies ***
Debian: <https://win-builder.r-project.org/incoming_pretest/ClusterR_1.3.3_20240617_091512/reverseDependencies/summary.txt>
tidyclust

Log dir: <https://win-builder.r-project.org/incoming_pretest/ClusterR_1.3.3_20240617_091512/>
The files will be removed after roughly 7 days.

Pretests:
Windows: <https://win-builder.r-project.org/incoming_pretest/ClusterR_1.3.3_20240617_091512/Windows/00check.log>
Debian: <https://win-builder.r-project.org/incoming_pretest/ClusterR_1.3.3_20240617_091512/Debian/00check.log>

Last published version on CRAN:

CRAN Web: <https://cran.r-project.org/package=ClusterR>

Best regards,
CRAN teams' auto-check service
Package check result: OK

Changes to worse in reverse depends:

Package: tidyclust
Check: tests
New result: ERROR
    Running ‘testthat.R’ [31s/31s]
  Running the tests in ‘tests/testthat.R’ failed.
  Complete output:
    > library(testthat)
    > library(tidyclust)
    >
    > test_check("tidyclust")
    [ FAIL 3 | WARN 0 | SKIP 48 | PASS 174 ]

    ══ Skipped tests (48) ══════════════════════════════════════════════════════════
    • On CRAN (48): 'test-arguments.R:27:3', 'test-arguments.R:35:3',
      'test-arguments.R:41:3', 'test-augment.R:31:3',
      'test-cluster_metric_set.R:24:3', 'test-cluster_metric_set.R:35:3',
      'test-cluster_metric_set.R:47:3', 'test-control.R:19:3',
      'test-engines.R:2:3', 'test-extract_centroids.R:4:3',
      'test-extract_centroids.R:15:3', 'test-extract_centroids.R:27:3',
      'test-extract_centroids.R:39:3', 'test-extract_cluster_assignment.R:4:3',
      'test-extract_cluster_assignment.R:15:3',
      'test-extract_cluster_assignment.R:27:3',
      'test-extract_cluster_assignment.R:39:3', 'test-extract_fit_summary.R:61:3',
      'test-fiting.R:7:3', 'test-hier_clust.R:29:3', 'test-hier_clust.R:179:3',
      'test-hier_clust.R:188:3', 'test-k_means-clustMixType.R:104:3',
      'test-k_means.R:40:3', 'test-k_means.R:108:3', 'test-k_means.R:117:3',
      'test-k_means.R:168:3', 'test-metric-silhouette.R:23:3',
      'test-metric-silhouette.R:32:3', 'test-metric-sse.R:4:3',
      'test-metric-sse.R:13:3', 'test-metric-sse.R:22:3', 'test-metric-sse.R:31:3',
      'test-predict.R:4:3', 'test-predict.R:15:3', 'test-predict.R:27:3',
      'test-predict.R:39:3', 'test-reconcile_clusterings.R:26:3',
      'test-reconcile_clusterings.R:48:3', 'test-tune_cluster.R:194:3',
      'test-tune_cluster.R:255:3', 'test-tune_cluster.R:283:3',
      'test-tune_cluster.R:295:3', 'test-tune_cluster.R:380:3',
      'test-tune_cluster.R:440:3', 'test-workflows.R:18:3',
      'test-workflows.R:41:3', 'test-workflows.R:65:3'

    ══ Failed tests ════════════════════════════════════════════════════════════════
    ── Failure ('test-k_means_diagnostics.R:38:3'): kmeans sse metrics work ────────
    sse_within(kmeans_fit_ClusterR)$wss (`actual`) not equal to c(42877.103, 56041.432, 4665.041) (`expected`).

      `actual`: 32838 11846 46659
    `expected`: 42877 56041  4665
    ── Failure ('test-k_means_diagnostics.R:53:3'): kmeans sse metrics work ────────
    sse_ratio_vec(kmeans_fit_ClusterR) (`actual`) not equal to 0.1661624 (`expected`).

      `actual`: 0.15
    `expected`: 0.17
    ── Failure ('test-k_means_diagnostics.R:114:3'): kmeans sihouette metrics work ──
    silhouette_avg_vec(kmeans_fit_ClusterR, dists = dists) (`actual`) not equal to 0.5473414 (`expected`).

      `actual`: 0.541
    `expected`: 0.547

    [ FAIL 3 | WARN 0 | SKIP 48 | PASS 174 ]
    Error: Test failures
    Execution halted

Would it be possible that the authors of tidyclust fix the issues using the current updated Github version of ClusterR before I re-submit to CRAN?

EmilHvitfeldt commented 5 months ago

Hello @mlampros !

I have fixed the issue in my test, and the updated version is now on CRAN.

github-actions[bot] commented 4 months ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.