tidymodels / workflows

Modeling Workflows
https://workflows.tidymodels.org/
Other
207 stars 23 forks source link

consider relocating tests for `tune_args()` and `tunable()` #194

Open simonpcouch opened 1 year ago

simonpcouch commented 1 year ago

As an additional comment... there are tests for tune_args() and tunable() methods in extratests:

do you think it's worth consolidating them with the tests here?

Originally posted by @hfrick in https://github.com/tidymodels/workflows/pull/193#pullrequestreview-1301528785

DavisVaughan commented 1 year ago

I think they are fine here because you only need workflows Imports/Suggests to test them and they are specific to workflows itself

hfrick commented 1 year ago

I think we needed the tests to be in extratests during the transition period of the various methods (or at least it was easier). I meant more "moving tests into workflows" rather than the other direction - if there's anything in those tests in extratests that isn't covered here already.