audit `should_inner_split()`

tidymodels / workflows

Modeling Workflows

https://workflows.tidymodels.org/

Other

205 stars 23 forks source link

audit `should_inner_split()` #230

Closed simonpcouch closed 4 months ago

simonpcouch commented 4 months ago

In:

https://github.com/tidymodels/workflows/blob/9e6ca982f8cd381cf4601cceb64f5ad323737476/R/fit.R#L101-L122

should_inner_split():

needs tests,
likely needs to be renamed, and,
needs to use information from the tailor that an author of external code could hook into

See code comments on each.

github-actions[bot] commented 3 months ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.