tidymodels / workflows

Modeling Workflows
https://workflows.tidymodels.org/
Other
205 stars 23 forks source link

transition from `add_tailor(prop)` and `method` to `fit.workflow(calibration)` #262

Closed simonpcouch closed 4 days ago

simonpcouch commented 1 week ago

Closes #255, closes #254, closes #252, closes #233, and related to this gist.

This PR removes the add_tailor(prop) and method arguments in favor of an argument fit.workflow(calibration) giving the data to fit the calibrator on.

Benefits:

Thanks @hfrick for this suggestion—this feels much better.

This PR should be much easier to review commit-by-commit than altogether.

TODOs from here: update tune and (possibly?) rename .should_inner_split() to something like .workflow_needs_calibration().