search

tidymodels / yardstick

Tidy methods for measuring model performance
https://yardstick.tidymodels.org/
Other
369 stars 55 forks source link

Error in curve function if `na_rm = FALSE` #344

Closed EmilHvitfeldt closed 9 months ago

EmilHvitfeldt commented 1 year ago

It is kind of weird that roc_curve() would return NA in the case of na_rm = FALSE and missing values, right?

Because we otherwise return a full tibble, so that isn't type stable.

I think this inconsistency probably already existed, but I think we should open an issue about this for all the curve functions. I imagine we should probably just error if na_rm = FALSE for a curve function and we actually detect missing values? That would be a nice way to take advantage of the fact that we have inlined the missing value handling into the metric function itself!

_Originally posted by @DavisVaughan in https://github.com/tidymodels/yardstick/pull/337#discussion_r1031458686_

github-actions[bot] commented 9 months ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.