search

tidypyverse / tidypandas

A grammar of data manipulation for pandas inspired by tidyverse
https://tidypyverse.github.io/tidypandas/
MIT License
91 stars 7 forks source link

Suggestions in joins #29

Closed talegari closed 1 year ago

talegari commented 1 year ago

@grahitr Please review:

  1. Allow user to control both suffix (x and y) -- right now only y is controllable. Defaults can be ["", "_y"] as it is currently there.
  2. If join columns differ in name, keep both left and right side ones. There no danger of loosing the data ever and keeps it simple for the user. This will keep the keep argument out which is primarily to maintain dplyr's back compatibility (we dont have to worry on this).
grahitr commented 1 year ago

@grahitr Please review:

1. Allow user to control both suffix (x and y) -- right now only y is controllable. Defaults can be `["", "_y"]` as it is currently there.

2. If join columns differ in name, keep both left and right side ones. There no danger of loosing the data ever and keeps it simple for the user. This will keep the `keep` argument out which is primarily to maintain dplyr's back compatibility (we dont have to worry on this).

Both of these look correct to me.

talegari commented 1 year ago

@grahitr Please review and merge: https://github.com/talegari/tidypandas/pull/30