search

tidypyverse / tidypandas

A grammar of data manipulation for pandas inspired by tidyverse
https://tidypyverse.github.io/tidypandas/
MIT License
91 stars 7 forks source link

bug: tidy_accessor joins and tidyframe joins have different method signatures. #39

Closed grahitr closed 1 year ago

grahitr commented 1 year ago

Tidyframe's joins have changed to accept one suffix argument in place of suffix_y. While tidy_accessor joins are still accepting suffix_y argument. In tidyframe

def left_join(self
                   , y
                   , on = None
                   , on_x = None
                   , on_y = None
                   , sort = True
                   , suffix = ["", "_y"]
                   ):

in tidy_accessor

def left_join(self
                   , y
                   , on = None
                   , on_x = None
                   , on_y = None
                   , sort = True
                   , suffix_y = "_y"
                   ):
grahitr commented 1 year ago

Also fix the following: