tidyverse / code-review

https://code-review.tidyverse.org/
32 stars 8 forks source link

See if there are valuable lessons from code review anxiety workbook #19

Open DavisVaughan opened 3 months ago

DavisVaughan commented 3 months ago

From @maelle

https://developer-success-lab.gitbook.io/code-review-anxiety-workbook-1

In particular https://developer-success-lab.gitbook.io/code-review-anxiety-workbook-1/part-two-managing-code-review-anxiety/step-4-proactively-engage/asking-like-a-dear https://developer-success-lab.gitbook.io/code-review-anxiety-workbook-1/part-two-managing-code-review-anxiety/step-4-proactively-engage/reviewing-to-give

These are nicely split into the reviewing vs authoring split that we use in our principles

maelle commented 3 months ago

I too particularly like the two acronym-things from step 4. :slightly_smiling_face: