search

tidyverse / datascience-box

Data Science Course in a Box
https://datasciencebox.org
Other
957 stars 427 forks source link

GitHub action to check rmd renders for PRs to course materials #104

Closed mine-cetinkaya-rundel closed 2 years ago

mine-cetinkaya-rundel commented 3 years ago

First crack at check rmd renders for PRs to course materials is here.

Currently, it's not working properly because git diff-tree --no-commit-id --name-only -r HEAD doesn't yield the expected result when running the action. This is evidenced by print(changed_rmd_files) yielding character(0) when, in reality, an Rmd file was changed in the PR.

@jimhester suggested this is likely because the pull request is likely checked out as a single commit without history.

Need to still find an alternative to git diff-tree --no-commit-id --name-only -r HEAD that works in this context.

Closes #103.

mine-cetinkaya-rundel commented 2 years ago

Will try a different approach when materials are transitioned to Quarto