tidyverse / dbplyr

Database (DBI) backend for dplyr
https://dbplyr.tidyverse.org
Other
474 stars 173 forks source link

Translations for namespaced functions must exist #1432

Closed hadley closed 8 months ago

hadley commented 9 months ago

I'm not sure how this broke, but the code for handling this already exists in translate_sql(), so I'm not sure why we started doing some :: handling in partial_eval().

Fixes #1426

mgirlich commented 9 months ago

We might also simply remove the compound calls logic in partial_eval_call(). At least no test failed when I removed it.

hadley commented 8 months ago

Let's tackle that in a separate PR. For example, .env$bar() currently errors, but maybe it's more consistent for it to be equivalent to local(bar())? Discussion in #1117.