search

tidyverse / dbplyr

Database (DBI) backend for dplyr
https://dbplyr.tidyverse.org
Other
474 stars 173 forks source link

Shim sql_escape_ident() for RMySQL #1470

Closed hadley closed 7 months ago

hadley commented 7 months ago

Since it doesn't appear to handle SQL objects. Fixes childesr revdep failure.

mgirlich commented 7 months ago

Why doe the checks fail? I couldn't reproduce this locally...

hadley commented 7 months ago

Hmmm, it's because the example doesn't have RMySQL loaded. I could fix that, but maybe it's better to remove the accidental hard dependency I added when simulating MySQL?

(TBH I'm actually surprised that loading RMySQL appears to fix the problem because we're passing an S3 object to an S4 generic)