search

tidyverse / dbplyr

Database (DBI) backend for dplyr
https://dbplyr.tidyverse.org
Other
469 stars 169 forks source link

date_count_between translations #1496

Open edward-burn opened 2 months ago

edward-burn commented 2 months ago

For #1495, adds translations for clock::date_count_between() for a number of backends along with tests and update of news.

edward-burn commented 2 days ago

@hadley I noticed there was now a conflict with the news file so I have fixed that. Would it be possible to review this pr, hopefully it adds some nice functionality? (the matching functionality was also added in the duckdb 1.0 release https://github.com/duckdb/duckdb-r/pull/166)

hadley commented 2 days ago

I’m not working on dbplyr at the moment but I’ll definitely do it when I next am. (And I’ll take care of any merge conflicts so you don’t need to worry about that)

edward-burn commented 2 days ago

No problem @hadley, thanks for letting me know. When you do get to dbplyr, please just tag me if anything needs to be done and I'd be more than happy to contribute (I'll also be coming to the tidyverse developer day, so happy to work on anything related then too!)

hadley commented 2 days ago

@edward-burn thank you! And looking forward to seeing you at TDD!