search

tidyverse / dplyr

dplyr: A grammar of data manipulation
https://dplyr.tidyverse.org/
Other
4.77k stars 2.12k forks source link

Hybrid version of uq() #2283

Closed krlmlr closed 7 years ago

krlmlr commented 7 years ago

so that mutate_(., f = ~mean(uq(var)) still uses the hybrid evaluator. (This requires that we switch to the "new" lazyeval first.)

Do we need hybrid handlers of uqs() and uqf()?

hadley commented 7 years ago

Adding @lionel- just so we talk about this when he implements tidyeval in dplyr.

lionel- commented 7 years ago

I think we'd want to only use the hybrid evaluator if we unquote a formula. So no hybrid versions of unquoting operators would be needed since the unquoted formulas get evaluated in the evaluation environment where hybrid functions are defined.

krlmlr commented 7 years ago

Hybrid versions are needed only for performance. I still see a case here with rlang and tidyeval, but this may not be top priority.