Release dplyr 1.0.0 - Githubissues

romainfrancois commented 4 years ago

Prepare for release:

[x] Check for open issues at https://github.com/tidyverse/dplyr/milestone/15
[x] devtools::build_readme()
[x] Check current CRAN check results
[x] devtools::check(remote = TRUE, manual = TRUE)
[x] devtools::check_win_devel()
[x] rhub::check_for_cran()
[x] rhub::check(platform = 'ubuntu-rchk')
[x] rhub::check_with_sanitizers()
[x] revdepcheck::revdep_check(num_workers = 4)
[x] Update cran-comments.md
[x] Polish NEWS
[x] Review pkgdown reference index for, e.g., missing topics
[x] Draft blog post

Submit to CRAN:

[x] usethis::use_version('major')
[x] devtools::submit_cran()
[x] Approve email

Wait for CRAN...

[x] Accepted :tada:
[x] usethis::use_github_release()
[x] usethis::use_dev_version()
[x] Finish blog post
[x] Tweet
[x] Add link to blog post in pkgdown news menu

romainfrancois commented 4 years ago

check_win_devel() is ok, after skip() a test that would fail for some reason: https://win-builder.r-project.org/e7PC1sjl8Abq/00check.log

* using log directory 'd:/RCompile/CRANguest/R-devel/dplyr.Rcheck'
* using R Under development (unstable) (2020-05-22 r78545)
* using platform: x86_64-w64-mingw32 (64-bit)
* using session charset: ISO8859-1
* checking for file 'dplyr/DESCRIPTION' ... OK
* checking extension type ... Package
* this is package 'dplyr' version '0.8.99.9003'
* package encoding: UTF-8
* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Hadley Wickham <romain@rstudio.com>'

Version contains large components (0.8.99.9003)

New maintainer:
  Hadley Wickham <romain@rstudio.com>
Old maintainer(s):
  Hadley Wickham <hadley@rstudio.com>

Found the following (possibly) invalid URLs:
  URL: http://swapi.co (moved to https://swapi.co/)
    From: inst/doc/dplyr.html
    Status: 404
    Message: Not Found
  URL: http://swapi.co/ (moved to https://swapi.co/)
    From: man/starwars.Rd
    Status: 404
    Message: Not Found
* checking package namespace information ... OK
* checking package dependencies ... OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking serialization versions ... OK
* checking whether package 'dplyr' can be installed ... OK
* checking installed package size ... OK
* checking package directory ... OK
* checking for future file timestamps ... OK
* checking 'build' directory ... OK
* checking DESCRIPTION meta-information ... OK
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking R files for non-ASCII characters ... OK
* checking R files for syntax errors ... OK
* loading checks for arch 'i386'
** checking whether the package can be loaded ... OK
** checking whether the package can be loaded with stated dependencies ... OK
** checking whether the package can be unloaded cleanly ... OK
** checking whether the namespace can be loaded with stated dependencies ... OK
** checking whether the namespace can be unloaded cleanly ... OK
** checking loading without being on the library search path ... OK
** checking use of S3 registration ... OK
* loading checks for arch 'x64'
** checking whether the package can be loaded ... OK
** checking whether the package can be loaded with stated dependencies ... OK
** checking whether the package can be unloaded cleanly ... OK
** checking whether the namespace can be loaded with stated dependencies ... OK
** checking whether the namespace can be unloaded cleanly ... OK
** checking loading without being on the library search path ... OK
** checking use of S3 registration ... OK
* checking dependencies in R code ... OK
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... [21s] OK
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd line widths ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... OK
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking contents of 'data' directory ... OK
* checking data for non-ASCII characters ... OK
* checking data for ASCII and uncompressed saves ... OK
* checking line endings in C/C++/Fortran sources/headers ... OK
* checking pragmas in C/C++ headers and code ... OK
* checking compiled code ... OK
* checking installed files from 'inst/doc' ... OK
* checking files in 'vignettes' ... OK
* checking examples ...
** running examples for arch 'i386' ... [23s] OK
** running examples for arch 'x64' ... [25s] OK
* checking for unstated dependencies in 'tests' ... OK
* checking tests ...
** running tests for arch 'i386' ... [35s] OK
  Running 'testthat.R' [35s]
** running tests for arch 'x64' ... [39s] OK
  Running 'testthat.R' [39s]
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in 'inst/doc' ... OK
* checking re-building of vignette outputs ... [25s] OK
* checking PDF version of manual ... OK
* checking for detritus in the temp directory ... OK
* DONE
Status: 1 NOTE

romainfrancois commented 4 years ago

rchk ✅ : https://github.com/tidyverse/dplyr/pull/5273

romainfrancois commented 4 years ago

current revdep status:

OK: 2319
BROKEN: 78

romainfrancois commented 4 years ago

library(tidyverse)

# cran <- readLines("https://win-builder.r-project.org/incoming_pretest/dplyr_1.0.0_20200529_015714/reverseDependencies/summary.txt") %>% 
#   grep("^Package: ", ., value = TRUE) %>% 
#   gsub("^Package: ", "", .) %>% 
#   gsub(" .*", " ", .) %>% 
#  unique()

cran <- c("amt", "analysisPipelines", "anomalize", "applicable", "bdl", 
  "bibliometrix", "bootnet", "bwsTools", "cattonum", "ciTools", 
  "codebook", "CollapseLevels", "convergEU", "correlationfunnel", 
  "cutpointr", "ddpcr", "diceR", "disk.frame", "DLMtool", "docxtools", 
  "driftR", "easyr", "eda4treeR", "edeaR", "egor", "episheet", 
  "expstudies", "fable", "fabletools", "feasts", "finalfit", "fingertipscharts", 
  "foieGras", "geometr", "getTBinR", "ggedit", "glmtree", "gratia", 
  "groupedstats", "HaDeX", "healthcareai", "HydeNet", "idmodelr", 
  "immunarch", "IncucyteDRC", "infer", "insurancerating", "jpndistrict", 
  "jstor", "keyATM", "lans2r", "lpirfs", "malariaAtlas", "mason", 
  "mcp", "metamicrobiomeR", "mmetrics", "naniar", "neuropsychology", 
  "opentripplanner", "pammtools", "panelr", "photobiology", "photosynthesis", 
  "PKNCA", "PKPDmisc", "pmdplyr", "PopED", "probably", "processcheckR", 
  "psychmeta", "ptstem", "rabhit", "ratPASTA", "RCMIP5", "rcv", 
  "RNeXML", "rsample", "RSDA", "RTL", "rules", "saotd", "sergeant", 
  "simglm", "simplevis", "SIRItoGTFS", "sistec", "skynet", "spatialEco", 
  "spinifex", "strapgod", "StratigrapheR", "sugarbag", "tcR", "tealeaves", 
  "tidyjson ", "tidyposterior", "tidyRSS", "tidystats", "tidystopwords", 
  "timetk", "tree.bins", "tsibble", "TSstudio", "vcfR", "vpc", 
  "xmrr", "yamlet")

known_broken <- c("AlphaBeta", "amt", "BMSC", "cattonum", "circRNAprofiler",
           "CollapseLevels", "cvms", "ddpcr", "DEGreport", "disk.frame",
           "DLMtool", "docxtools", "driftR", "easyr", "eda4treeR", "egor",
           "episheet", "expstudies", "fabletools", "fingertipscharts", "foieGras",
           "geometr", "geomnet", "getTBinR", "ggedit", "gratia", "HaDeX",
           "healthcareai", "idmodelr", "isomiRs", "lans2r", "LexisNexisTools",
           "mmetrics", "MSstatsTMT", "neuropsychology", "ngsReports", "opentripplanner",
           "pammtools", "PAST", "photosynthesis", "pmdplyr", "rabhit", "ratPASTA",
           "RCMIP5", "rsample", "saotd", "sergeant", "sevenbridges", "simglm",
           "SIRItoGTFS", "skynet", "strapgod", "StratigrapheR", "tidyjson",
           "tidyRSS", "tidystats", "tidystopwords", "timeOmics", "TPP",
           "tree.bins", "treeplyr", "vcfR", "vpc", "yamlet")

setdiff(cran, known_broken)
#>  [1] "analysisPipelines" "anomalize"         "applicable"       
#>  [4] "bdl"               "bibliometrix"      "bootnet"          
#>  [7] "bwsTools"          "ciTools"           "codebook"         
#> [10] "convergEU"         "correlationfunnel" "cutpointr"        
#> [13] "diceR"             "edeaR"             "fable"            
#> [16] "feasts"            "finalfit"          "glmtree"          
#> [19] "groupedstats"      "HydeNet"           "immunarch"        
#> [22] "IncucyteDRC"       "infer"             "insurancerating"  
#> [25] "jpndistrict"       "jstor"             "keyATM"           
#> [28] "lpirfs"            "malariaAtlas"      "mason"            
#> [31] "mcp"               "metamicrobiomeR"   "naniar"           
#> [34] "panelr"            "photobiology"      "PKNCA"            
#> [37] "PKPDmisc"          "PopED"             "probably"         
#> [40] "processcheckR"     "psychmeta"         "ptstem"           
#> [43] "rcv"               "RNeXML"            "RSDA"             
#> [46] "RTL"               "rules"             "simplevis"        
#> [49] "sistec"            "spatialEco"        "spinifex"         
#> [52] "sugarbag"          "tcR"               "tealeaves"        
#> [55] "tidyjson "         "tidyposterior"     "timetk"           
#> [58] "tsibble"           "TSstudio"          "xmrr"
intersect(cran, known_broken)
#>  [1] "amt"              "cattonum"         "CollapseLevels"   "ddpcr"           
#>  [5] "disk.frame"       "DLMtool"          "docxtools"        "driftR"          
#>  [9] "easyr"            "eda4treeR"        "egor"             "episheet"        
#> [13] "expstudies"       "fabletools"       "fingertipscharts" "foieGras"        
#> [17] "geometr"          "getTBinR"         "ggedit"           "gratia"          
#> [21] "HaDeX"            "healthcareai"     "idmodelr"         "lans2r"          
#> [25] "mmetrics"         "neuropsychology"  "opentripplanner"  "pammtools"       
#> [29] "photosynthesis"   "pmdplyr"          "rabhit"           "ratPASTA"        
#> [33] "RCMIP5"           "rsample"          "saotd"            "sergeant"        
#> [37] "simglm"           "SIRItoGTFS"       "skynet"           "strapgod"        
#> [41] "StratigrapheR"    "tidyRSS"          "tidystats"        "tidystopwords"   
#> [45] "tree.bins"        "vcfR"             "vpc"              "yamlet"

^{Created on 2020-05-29 by the reprex package (v0.3.0)}

romainfrancois commented 4 years ago

Here's the breakdown locally, I'll test the 60 packages again now:


still failing: 

  analysisPipelines
  anomalize
  bdl
  bibliometrix
  bootnet
  bwsTools
  codebook
  convergEU
  correlationfunnel
  cutpointr
  diceR
  fable
  finalfit
  groupedstats
  HydeNet
  IncucyteDRC
  infer
  jpndistrict
  jstor
  keyATM
  lpirfs
  malariaAtlas
  mason
  mcp
  metamicrobiomeR
  panelr
  photobiology
  PKPDmisc
  PopED
  psychmeta
  ptstem
  rcv
  RTL
  simplevis
  spatialEco
  spinifex
  sugarbag
  tealeaves
  timetk
  tsibble
  TSstudio

broken:

  tidyjson

new: 

  applicable
  immunarch
  rules
  sistec

ok: 

  ciTools
  edeaR
  feasts
  glmtree
  insurancerating
  naniar
  PKNCA
  probably
  processcheckR
  RNeXML
  RSDA
  tcR
  tidyposterior
  xmrr

dpastoor commented 4 years ago

Hmm fyi I'm the maintainer of PKPDmisc which I see made the failing list. I haven't gotten a notification email or anything about that - I only discovered as I've been generally watching the progress of the repo. I can check that and get a fix in shortly. you might also want to check whatever email blast or other correspondence that is being sent out to maintainers of these packages actually made it to them and isn't getting filtered.

tidyverse / dplyr

Release dplyr 1.0.0 #5225