Release dplyr 1.0.6 - Githubissues

romainfrancois commented 3 years ago

Prepare for release:

[x] devtools::build_readme()
[x] Check current CRAN check results
[x] devtools::check(remote = TRUE, manual = TRUE)
[x] devtools::check_win_devel()
[x] rhub::check_for_cran()
[x] rhub::check(platform = 'ubuntu-rchk')
[x] rhub::check_with_sanitizers()
[x] revdepcheck::revdep_check(num_workers = 4)
[x] urlchecker::url_check()
[x] Update cran-comments.md
[x] Polish NEWS

Submit to CRAN:

[x] usethis::use_version('patch')
[x] devtools::submit_cran()
[ ] Approve email

Wait for CRAN...

[x] Accepted :tada:
[x] usethis::use_github_release()
[x] usethis::use_dev_version()

romainfrancois commented 3 years ago

revdep problems. Looks fine:

banR: internet error: The API sent back an error 502
DeLorean: lots of compilation noise, but independent from dplyr
imfr: internet error too: Unable to download series.

romainfrancois commented 3 years ago

I think it's all good to start submit, but 1.0.5 is only 6 days old.

romainfrancois commented 3 years ago

Will initiate again once #5815 is merged

romainfrancois commented 3 years ago

rhub::check(platform = 'ubuntu-rchk') fails because of bioc: https://builder.r-hub.io/status/dplyr_1.0.5.9000.tar.gz-ceff15c4508a4b41a8c4a719e58fbb04#L267

        #> Error: Bioconductor version '3.13' requires R version '4.1'; R version is too new; see
 268#> https://bioconductor.org/install
 269#> Execution halted
 270#> Error: Bioconductor version '3.13' requires R version '4.1'; R version is too new; see
 271#> https://bioconductor.org/install

I could not test locally either because of some other problem.

romainfrancois commented 3 years ago

rev dep checks 1c071bc3-3ea2-4d67-bd7c-aab06caf9450 give:

## New problems (20)

|package                                             |version |error  |warning |note     |
|:---------------------------------------------------|:-------|:------|:-------|:--------|
|[codebook](problems.md#codebook)                    |0.9.2   |__+1__ |        |3        |
|[DAISIE](problems.md#daisie)                        |3.0.1   |__+1__ |        |1        |
|[diseq](problems.md#diseq)                          |0.2.1   |__+2__ |        |1        |
|[disk.frame](problems.md#diskframe)                 |0.4.1   |       |__+1__  |__+1__   |
|[egor](problems.md#egor)                            |0.21.02 |__+2__ |1       |         |
|[EpiNow2](problems.md#epinow2)                      |1.3.2   |-1     |        |1 __+1__ |
|[ggasym](problems.md#ggasym)                        |0.1.5   |__+1__ |        |         |
|[groupedstats](problems.md#groupedstats)            |2.0.1   |__+1__ |        |         |
|[lpirfs](problems.md#lpirfs)                        |0.2.0   |__+1__ |        |1        |
|[mason](problems.md#mason)                          |0.3.0   |__+1__ |        |         |
|[mcp](problems.md#mcp)                              |0.3.0   |__+1__ |        |         |
|[mdsr](problems.md#mdsr)                            |0.2.5   |__+1__ |        |1        |
|[modeltime](problems.md#modeltime)                  |0.5.1   |__+2__ |        |         |
|[modeltime.resample](problems.md#modeltimeresample) |0.2.0   |__+2__ |1       |1        |
|[mrgsolve](problems.md#mrgsolve)                    |0.11.0  |__+1__ |        |1        |
|[panelr](problems.md#panelr)                        |0.7.5   |__+2__ |        |1        |
|[ratPASTA](problems.md#ratpasta)                    |0.1.2   |__+1__ |        |1        |
|[readabs](problems.md#readabs)                      |0.4.8   |__+1__ |        |         |
|[rsetse](problems.md#rsetse)                        |0.4.0   |__+1__ |        |         |
|[skimr](problems.md#skimr)                          |2.1.3   |__+2__ |        |         |

romainfrancois commented 3 years ago

codebook failure is inherited from skimr, probably fixed by #5863. diseq seems to have a similar issue. egor too

romainfrancois commented 3 years ago

DAISIE can't test locally for lack of a good fortran setup, @rsetienne can you have a look ? I'll open an issue on the DAISIE repo.

romainfrancois commented 3 years ago

disk.frame seems to break because add_count() has become generic:

cloud_details(,"disk.frame")
══ Reverse dependency check ══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════ disk.frame 0.4.1 ══

Status: BROKEN

── Newly failing

x checking S3 generic/method consistency ... WARNING
x checking Rd \usage sections ... NOTE

── Before ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
0 errors ✓ | 0 warnings ✓ | 0 notes ✓

── After ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
> checking S3 generic/method consistency ... WARNING
  add_count:
    function(x, ..., wt, sort, name, .drop)
  add_count.disk.frame:
    function(.data, ...)

  See section ‘Generic functions and methods’ in the ‘Writing R
  Extensions’ manual.

  Found the following apparent S3 methods exported but not registered:
    add_count.disk.frame
  See section ‘Registering S3 methods’ in the ‘Writing R Extensions’
  manual.

> checking Rd \usage sections ... NOTE
  S3 methods shown with full name in documentation object 'select.disk.frame':
    ‘add_count.disk.frame’

  The \usage entries for S3 methods should use the \method markup and not
  their full name.
  See chapter ‘Writing R documentation files’ in the ‘Writing R
  Extensions’ manual.

0 errors ✓ | 1 warning x | 1 note x

@xiaodaigh can you have a look ?

romainfrancois commented 3 years ago

EpiNow problem appears unrelated to dplyr and produces a very very long compiler error message from RcppEigen. @seabbs is this something on your radar ?

romainfrancois commented 3 years ago

pull request for ggasym https://github.com/jhrcook/ggasym/pull/28

romainfrancois commented 3 years ago

revdep 51ac3c19-bae6-4f17-b8aa-4ccd9de1f7fe :

## New problems (8)

|package                             |version  |error  |warning |note   |
|:-----------------------------------|:--------|:------|:-------|:------|
|[AMR](problems.md#amr)              |1.6.0    |__+1__ |        |1      |
|[disk.frame](problems.md#diskframe) |0.4.1    |       |__+1__  |__+1__ |
|[EpiNow2](problems.md#epinow2)      |1.3.2    |-1     |        |__+1__ |
|[ggasym](problems.md#ggasym)        |0.1.5    |__+1__ |        |       |
|[mcp](problems.md#mcp)              |0.3.0    |__+1__ |        |       |
|[mrgsolve](problems.md#mrgsolve)    |0.11.0   |__+1__ |        |1      |
|[ratPASTA](problems.md#ratpasta)    |0.1.2    |__+1__ |        |1      |
|[spatPomp](problems.md#spatpomp)    |0.21.0.0 |__+1__ |1       |1      |

romainfrancois commented 3 years ago

pull request for mrgsolve https://github.com/metrumresearchgroup/mrgsolve/pull/816

romainfrancois commented 3 years ago

pull request for ratPASTA https://github.com/ikodvanj/ratPASTA/pull/2

xiaodaigh commented 3 years ago

@xiaodaigh can you have a look ?

btw this was fixed in disk.frame

romainfrancois commented 3 years ago

AMR fixed in dev version

romainfrancois commented 3 years ago

pull request sent to mcp : https://github.com/lindeloev/mcp/pull/119

tidyverse / dplyr

Release dplyr 1.0.6 #5810