Release dplyr 1.0.8 - Githubissues

tidyverse / dplyr

dplyr: A grammar of data manipulation

https://dplyr.tidyverse.org/

Other

4.78k stars 2.12k forks source link

Release dplyr 1.0.8 #6080

Closed romainfrancois closed 2 years ago

romainfrancois commented 2 years ago

Prepare for release:

[x] Check current CRAN check results
[x] Polish NEWS
[x] devtools::build_readme()
[x] urlchecker::url_check()
[x] devtools::check(remote = TRUE, manual = TRUE)
[x] devtools::check_win_devel()
[x] rhub::check_for_cran()
[x] rhub::check(platform = 'ubuntu-rchk')
[x] rhub::check_with_sanitizers()
[x] revdepcheck::cloud_check() : 11 new problems / 16 failed to check / 3196
[x] Update cran-comments.md

Submit to CRAN:

[x] usethis::use_version('patch')
[x] devtools::submit_cran()
[x] Approve email

Wait for CRAN...

[x] Accepted :tada:
[x] usethis::use_github_release()
[x] usethis::use_dev_version()

romainfrancois commented 2 years ago

initial revdep:

## New problems (54)

|package                                 |version |error    |warning |note   |
|:---------------------------------------|:-------|:--------|:-------|:------|
|[AATtools](problems.md#aattools)        |0.0.1   |__+1__   |        |       | .  
|[arrow](problems.md#arrow)              |6.0.0.2 |__+1__   |        |1      | .
|[bigsnpr](problems.md#bigsnpr)          |1.8.1   |__+1__   |        |1      | .
|[bruceR](problems.md#brucer)            |0.7.3   |__+1__   |        |       | .
|[cohorts](problems.md#cohorts)          |1.0.0   |__+1__   |        |       | > dtplyr
|[datacleanr](problems.md#datacleanr)    |1.0.2   |__+1__   |        |1      | .
|[dm](problems.md#dm)                    |0.2.5   |__+1__   |        |       | .
|[dtplyr](problems.md#dtplyr)            |1.1.0   |__+2__   |        |__+1__ | .
|[dynfeature](problems.md#dynfeature)    |1.0.0   |__+1__   |        |1      | .
|[dynplot](problems.md#dynplot)          |1.1.1   |__+1__   |        |       | .
|[egor](problems.md#egor)                |1.21.10 |1 __+1__ |        |       | .
|[ergm.ego](problems.md#ergmego)         |1.0.0   |         |__+1__  |       | .
|[fable](problems.md#fable)              |0.3.1   |__+2__   |        |       | ?
|[fabletools](problems.md#fabletools)    |0.3.1   |__+2__   |        |       | ?
|[gestalt](problems.md#gestalt)          |0.1.8   |__+1__   |        |       | v
|[ggcharts](problems.md#ggcharts)        |0.2.1   |__+1__   |        |       | .
|[huxtable](problems.md#huxtable)        |5.4.0   |__+1__   |        |1      | .
|[immunarch](problems.md#immunarch)      |0.6.7   |__+1__   |        |2      | > dtplyr
|[isoreader](problems.md#isoreader)      |1.3.1   |__+1__   |        |1      | .
|[janitor](problems.md#janitor)          |2.1.0   |__+2__   |        |       | .
|[lares](problems.md#lares)              |5.0.2   |__+1__   |        |       | v
|[manymodelr](problems.md#manymodelr)    |0.3.6   |__+1__   |        |       | .
|[microeco](problems.md#microeco)        |0.5.1   |         |__+1__  |1      | .
|[Momocs](problems.md#momocs)            |1.3.2   |__+1__   |        |       | .
|[motif](problems.md#motif)              |0.5.0   |__+1__   |        |1      | . 
|[MRFcov](problems.md#mrfcov)            |1.0.38  |__+1__   |        |       | .
|[multidplyr](problems.md#multidplyr)    |0.1.0   |__+1__   |        |1      | .
|[multifear](problems.md#multifear)      |0.1.2   |__+1__   |        |1      | .
|[nofrills](problems.md#nofrills)        |0.3.1   |__+2__   |        |       | .
|[pammtools](problems.md#pammtools)      |0.5.7   |__+1__   |        |       | ?
|[PPforest](problems.md#ppforest)        |0.1.2   |__+1__   |        |1      | .
|[prider](problems.md#prider)            |1.0.2   |__+1__   |        |       | .
|[psfmi](problems.md#psfmi)              |1.0.0   |__+1__   |        |1      | .
|[psycModel](problems.md#psycmodel)      |0.3.2   |__+1__   |        |1      | .
|[PVplr](problems.md#pvplr)              |0.1.0   |__+1__   |        |1      | .
|[r2dii.match](problems.md#r2diimatch)   |0.0.11  |__+1__   |        |       | v
|[saeSim](problems.md#saesim)            |0.10.0  |__+2__   |        |       | v
|[sapfluxnetr](problems.md#sapfluxnetr)  |0.1.2   |__+1__   |        |1      | .
|[SimplyAgree](problems.md#simplyagree)  |0.0.2   |__+1__   |        |       | .
|[srvyr](problems.md#srvyr)              |1.1.0   |__+1__   |        |       | x
|[tangram.pipe](problems.md#tangrampipe) |1.1.0   |__+1__   |        |       | .
|[tbrf](problems.md#tbrf)                |0.1.5   |__+1__   |        |       | .
|[TeachHist](problems.md#teachhist)      |0.1.2   |__+1__   |        |       | v
|[testdat](problems.md#testdat)          |0.3.0   |__+1__   |        |       | .
|[texter](problems.md#texter)            |0.1.9   |__+1__   |        |       | .
|[tidyMicro](problems.md#tidymicro)      |1.47    |__+2__   |        |1      | .
|[tidyquery](problems.md#tidyquery)      |0.2.2   |__+1__   |        |       | .
|[timetk](problems.md#timetk)            |2.6.1   |__+1__   |        |2      | fixed already
|[Tplyr](problems.md#tplyr)              |0.4.2   |__+1__   |        |       | .
|[tsibble](problems.md#tsibble)          |1.1.0   |__+1__   |        |       | .
|[validata](problems.md#validata)        |0.1.0   |__+1__   |        |1      | .
|[widyr](problems.md#widyr)              |0.1.4   |__+1__   |        |1      | v
|[xpose](problems.md#xpose)              |0.4.13  |__+2__   |        |       | .
|[yardstick](problems.md#yardstick)      |0.0.8   |__+1__   |        |       |

romainfrancois commented 2 years ago

romainfrancois commented 2 years ago

Potential issue with transmute() keeping existing columns in place (https://github.com/tidyverse/dplyr/issues/5967 fixed in https://github.com/tidyverse/dplyr/pull/6035).

This revdep-breaks packages bigsnpr and dynfeature which seemed to be using transmute() to do both mutate() and `select():

bigsnpr : https://github.com/privefl/bigsnpr/pull/274 dynfeature: https://github.com/dynverse/dynfeature/pull/10

dynfeature has :

         transmute(
            milestone_id = factor(milestone_oi, levels = trajectory$milestone_ids),
            .data$feature_id,
            .data$importance
          )

with the intent that the variables will be in this order. Under the current release candidate, we'd need to add e.g.

         %>% select(all_of(c("milestone_id", "feature_id", "importance")))

This pull request: https://github.com/dynverse/dynfeature/pull/10

This seems to be a pattern. Should transmute() offer some option to allow it ? cc @DavisVaughan

DavisVaughan commented 2 years ago

I think my main takeaway in #6035 was that mixing the behaviors of .keep with column ordering is what made it incredibly hard to begin with.

An important invariant that falls out here is that .keep plays no role in the column ordering, and I think that is valuable. I think giving keep = "none" special behavior in a few places that changed column order is what made this so hard to get correct before.

I would love to avoid adding that back in unless we absolutely have to.

I also like that transmute() is currently just mutate(.keep="none"), so it would feel wrong to give transmute() some extra option that mutate() doesn't have.

I really think that mixing mutation and selection into the same operation is just too hard to get perfectly right, so swapping these transmute()s out for a more explicit but simpler mutate() + select() is better in my mind.

Happy to help with other revdeps if this comes up in other places

eitsupi commented 2 years ago

Hello. Thank you for the continuous development of this wonderful package.

The changes to transmute in this release will be destructive to users (including me) who assumed that they could sort to any position like select, but the version will it be 1.0.8? (patch update?)

eitsupi commented 2 years ago

@romainfrancois As discussed in this comment https://github.com/privefl/bigsnpr/pull/274#discussion_r749363632, I think it will break a lot of code.

For example, I am using transmute in the following place, which expects the output to look like the image, but the change in transmute will change the display of the table.

https://github.com/rocker-org/rocker-versioned2/blob/af70656acb5ee085cd6e33f9a3f5856bf9bbedbc/build/reports/wiki_home.Rmd#L127-L136

https://github.com/rocker-org/rocker-versioned2/wiki

I happened to notice that such a release is planned and I have grace to rewrite it with mutate and select from now on, but it is possible that many users are not aware of it. I think it would be helpful if you could spread the word about this change on tidyverse blog, as like readr 2.1.0. (Actually, I'd like to see transmute's behavior stay the same...)

romainfrancois commented 2 years ago

We are going through the reverse dependencies, and for now the evidence disagrees with the expectation that it will break a lot of code.

We understand the frustration but this is something that has changed a few times, and so we would not recommend the pattern of using transmute() to both mutate() and select(). Things are much more predictable when you don't mix mutation and selection.

DavisVaughan commented 2 years ago

I have gone through the history of the behavior of transmute() regarding the order of the resulting columns. It turns out that the CRAN behavior of transmute() has always (as far back as 0.8.3 at least) ignored the pre-existing ordering of the columns.

So this would be the first time this behavior would be changed.

It is a confusing history. In the dev version of what became 1.0.0, the behavior was changed, but then reverted back four days later, before it ever made it to CRAN, which caused us to think that this has changed multiple times throughout the history of dplyr.

In light of the fact that this has never changed in the past, we will take another look at this behavior, and I think we should consider retaining the CRAN behavior, even if I think the new behavior is overall more consistent.

Here is the timeline:

library(dplyr)

df <- tibble(
  x = 1:3,
  y = 4:6
)

# What column order should this return?
transmute(df, x = x + 1, z = x + 1, y = y + 1)

# 2019-07-04
# devtools::install_version("dplyr", "0.8.3")
# "Incorrectly" re-orders the modified pre-existing variables. Theoretically
# should be (x, y, z) because that retains the ordering of pre-existing vars.
#> # A tibble: 3 × 3
#>       x     z     y
#>   <dbl> <dbl> <dbl>
#> 1     2     3     5
#> 2     3     4     6
#> 3     4     5     7

# 2020-01-05
# The above behavior was noticed in
# https://github.com/tidyverse/dplyr/issues/4693
# Fixed in
# https://github.com/tidyverse/dplyr/pull/4694

# 2020-01-08
# Then reverted when we got this issue 3 days later
# https://github.com/tidyverse/dplyr/issues/4717
# It was reverted in this PR
# (big PR, but you can see the test changed)
# https://github.com/tidyverse/dplyr/pull/4715
# So this change never made it into 0.8.4 or 1.0.0!
# 1.0.0 still had the "incorrect" behavior in `.keep="none"` and `transmute()`.

# 2021-08-02
# This was brought up again in
# https://github.com/tidyverse/dplyr/issues/5967
# It was pitched as a regression for #4693, but that
# never actually made it to CRAN so it was not a regression
# of any CRAN behavior.
#
# This was closed in
# https://github.com/tidyverse/dplyr/pull/6035
# where I changed `.keep = "none"` and therefore `transmute()` to be more
# consistent with the other `.keep` options. But this is actually the first
# time this behavior has ever really changed for `transmute()` (if we send
# this to CRAN as is).

romainfrancois commented 2 years ago

Round 2

## New problems (37)

|package                                |version |error  |warning |note |
|:--------------------------------------|:-------|:------|:-------|:----|
|[arrow](problems.md#arrow)             |6.0.0.2 |__+1__ |        |1    |
|[cvms](problems.md#cvms)               |1.3.3   |__+1__ |        |     |
|[datacleanr](problems.md#datacleanr)   |1.0.2   |__+1__ |        |1    |
|[dm](problems.md#dm)                   |0.2.5   |__+1__ |        |     |
|[dtplyr](problems.md#dtplyr)           |1.1.0   |__+2__ |        |     |
|[dynplot](problems.md#dynplot)         |1.1.1   |__+1__ |        |     |
|[ergm.ego](problems.md#ergmego)        |1.0.0   |       |__+1__  |     |
|[fable](problems.md#fable)             |0.3.1   |__+2__ |        |     |
|[fabletools](problems.md#fabletools)   |0.3.1   |__+2__ |        |     |
|[gestalt](problems.md#gestalt)         |0.1.8   |__+1__ |        |     |
|[immunarch](problems.md#immunarch)     |0.6.7   |__+1__ |        |2    |
|[isoreader](problems.md#isoreader)     |1.3.1   |__+1__ |        |1    |
|[keyholder](problems.md#keyholder)     |0.1.5   |__+1__ |        |     |
|[manymodelr](problems.md#manymodelr)   |0.3.7   |__+1__ |        |     |
|[mcp](problems.md#mcp)                 |0.3.1   |__+1__ |        |     |
|[microeco](problems.md#microeco)       |0.6.0   |       |__+1__  |2    |
|[MoMPCA](problems.md#mompca)           |1.0.1   |__+1__ |        |1    |
|[motif](problems.md#motif)             |0.5.0   |__+1__ |        |1    |
|[multidplyr](problems.md#multidplyr)   |0.1.0   |__+1__ |        |1    |
|[multinma](problems.md#multinma)       |0.3.0   |__+1__ |        |3    |
|[nofrills](problems.md#nofrills)       |0.3.1   |__+2__ |        |     |
|[pammtools](problems.md#pammtools)     |0.5.7   |__+1__ |        |     |
|[PPforest](problems.md#ppforest)       |0.1.2   |__+1__ |        |1    |
|[prider](problems.md#prider)           |1.0.2   |__+1__ |        |     |
|[PVplr](problems.md#pvplr)             |0.1.0   |__+1__ |        |1    |
|[ruler](problems.md#ruler)             |0.2.4   |__+2__ |        |     |
|[sapfluxnetr](problems.md#sapfluxnetr) |0.1.2   |__+1__ |        |1    |
|[shinymodels](problems.md#shinymodels) |0.1.0   |       |__+1__  |1    |
|[srvyr](problems.md#srvyr)             |1.1.0   |__+1__ |        |     |
|[tbrf](problems.md#tbrf)               |0.1.5   |__+1__ |        |     |
|[testdat](problems.md#testdat)         |0.3.0   |__+1__ |        |     |
|[tidyMicro](problems.md#tidymicro)     |1.47    |__+2__ |        |1    |
|[tidyquery](problems.md#tidyquery)     |0.2.2   |__+1__ |        |     |
|[timetk](problems.md#timetk)           |2.6.2   |__+1__ |        |1    |
|[Tplyr](problems.md#tplyr)             |0.4.2   |__+1__ |        |     |
|[tsibble](problems.md#tsibble)         |1.1.0   |__+1__ |        |     |
|[yardstick](problems.md#yardstick)     |0.0.8   |__+1__ |        |     |

romainfrancois commented 2 years ago

Round 4:

## New problems (23)

|package                                |version |error  |warning |note |
|:--------------------------------------|:-------|:------|:-------|:----|
|[dtplyr](problems.md#dtplyr)           |1.1.0   |__+2__ |        |     | ready to be released
|[dynplot](problems.md#dynplot)         |1.1.1   |__+1__ |        |     | fixed in tidyr
|[ergm.ego](problems.md#ergmego)        |1.0.0   |       |__+1__  |     | pr
|[excluder](problems.md#excluder)       |0.3.2   |__+2__ |        |     | pr
|[gestalt](problems.md#gestalt)         |0.1.8   |__+1__ |        |     | ready, waits for rlang
|[immunarch](problems.md#immunarch)     |0.6.7   |__+1__ |        |2    | caused by dtplyr
|[keyholder](problems.md#keyholder)     |0.1.5   |__+1__ |        |     | ? maybe a transmute() thing
|[mcp](problems.md#mcp)                 |0.3.1   |__+1__ |        |     | ?
|[microeco](problems.md#microeco)       |0.6.0   |       |__+1__  |2    | pr
|[MoMPCA](problems.md#mompca)           |1.0.1   |__+2__ |        |1    | false error, seems alright
|[motif](problems.md#motif)             |0.5.0   |__+1__ |        |1    | pb with slice() #6084 
|[nofrills](problems.md#nofrills)       |0.3.1   |__+2__ |        |     | rlang issue
|[pammtools](problems.md#pammtools)     |0.5.7   |__+1__ |        |     | ready to be released
|[PPforest](problems.md#ppforest)       |0.1.2   |__+1__ |        |1    | pr or #6112 
|[prider](problems.md#prider)           |1.0.2   |__+1__ |        |     | fixed in dev version
|[PVplr](problems.md#pvplr)             |0.1.0   |__+1__ |        |1    | email sent
|[ruler](problems.md#ruler)             |0.2.4   |__+2__ |        |     | issue
|[shinymodels](problems.md#shinymodels) |0.1.0   |       |__+1__  |1    | fixed in dev
|[testdat](problems.md#testdat)         |0.3.0   |__+1__ |        |     | fixed in dev
|[tidyMicro](problems.md#tidymicro)     |1.47    |__+2__ |        |1    | pr
|[tidyquery](problems.md#tidyquery)     |0.2.2   |__+1__ |        |     | pr
|[timetk](problems.md#timetk)           |2.6.2   |__+1__ |        |1    | fixed in dev
|[tsibble](problems.md#tsibble)         |1.1.0   |__+1__ |        |     | pr

romainfrancois commented 2 years ago

excluder: https://github.com/ropensci/excluder/pull/7 keyholder: not sure, perhaps an issue with the transmute() fixes lately. https://github.com/echasnovski/keyholder/issues/6 pammtools: about to be released: https://github.com/adibender/pammtools/issues/207 ruler: https://github.com/echasnovski/ruler/issues/10 shinymodels: https://github.com/tidymodels/shinymodels/pull/68 timetk: https://github.com/business-science/timetk/pull/98

romainfrancois commented 2 years ago

https://github.com/tidyverse/dplyr/pull/6112 deals with PPforest

romainfrancois commented 2 years ago

Round 5: 2021-12-08

## New problems (7)

|package                               |version |error    |warning |note |
|:-------------------------------------|:-------|:--------|:-------|:----|
|[gestalt](problems.md#gestalt)        |0.1.8   |__+1__   |        |     | rlang issue
|[healthyR.ts](problems.md#healthyrts) |0.1.6   |__+1__   |        |2    |
|[nofrills](problems.md#nofrills)      |0.3.1   |1 __+1__ |        |1    |
|[PPforest](problems.md#ppforest)      |0.1.2   |__+1__   |        |1    |
|[prider](problems.md#prider)          |1.0.2   |__+1__   |        |     |
|[PVplr](problems.md#pvplr)            |0.1.0   |__+1__   |        |1    |
|[timetk](problems.md#timetk)          |2.6.2   |__+1__   |        |1    |

however, there was many (642) failed to check, that might be due to AWS issues.

romainfrancois commented 2 years ago

Now that rlang is released:

# Revdeps

## Failed to check (11)

|package        |version |error |warning |note |
|:--------------|:-------|:-----|:-------|:----|
|accept         |?       |      |        |     |
|CausalImpact   |?       |      |        |     |
|cbar           |?       |      |        |     |
|conos          |1.4.5   |1     |        |     |
|geocmeans      |?       |      |        |     |
|loon.ggplot    |?       |      |        |     |
|loon.shiny     |?       |      |        |     |
|MarketMatching |?       |      |        |     |
|PLNmodels      |0.11.5  |1     |        |     |
|RAQSAPI        |2.0.2   |1     |        |     |
|vivid          |?       |      |        |     |

## New problems (14)

|package                                            |version |error  |warning |note     |
|:--------------------------------------------------|:-------|:------|:-------|:--------|
|[chunked](problems.md#chunked)                     |0.5.1   |__+1__ |        |1 __+1__ |
|[collapse](problems.md#collapse)                   |1.7.3   |__+1__ |        |1        |
|[covid19br](problems.md#covid19br)                 |0.1.3   |       |__+1__  |2        |
|[functiondepends](problems.md#functiondepends)     |0.2.1   |       |__+1__  |1        |
|[mcp](problems.md#mcp)                             |0.3.1   |__+1__ |        |         |
|[motif](problems.md#motif)                         |0.5.0   |__+1__ |        |1        |
|[nomisr](problems.md#nomisr)                       |0.4.4   |       |__+1__  |         |
|[photobiology](problems.md#photobiology)           |0.10.8  |__+1__ |__+2__  |         |
|[photobiologyInOut](problems.md#photobiologyinout) |0.4.23  |__+1__ |__+1__  |1        |
|[prider](problems.md#prider)                       |1.0.2   |__+1__ |        |         |
|[saeSim](problems.md#saesim)                       |0.10.0  |__+2__ |__+1__  |__+1__   |
|[salem](problems.md#salem)                         |0.2.0   |       |__+1__  |         |
|[sfnetworks](problems.md#sfnetworks)               |0.5.4   |       |__+1__  |         |
|[telemac](problems.md#telemac)                     |0.1.0   |       |__+1__  |2        |

romainfrancois commented 2 years ago

chunked : pull request https://github.com/edwindj/chunked/pull/21 collapse: sent pull request: https://github.com/SebKrantz/collapse/pull/212 covid19br: ~pull request https://github.com/fndemarqui/covid19br/pull/1 but might be a dplyr issue.~ https://github.com/tidyverse/dplyr/pull/6171 functiondepends : pull request https://github.com/jakubsob/functiondepends/pull/2 mcp: issue https://github.com/lindeloev/mcp/issues/140 motif: issue https://github.com/Nowosad/motif/issues/66 nomisr : fixed in dev, https://github.com/ropensci/nomisr/issues/29 photobiology: fixed in dev https://github.com/aphalo/photobiology/issues/6 photobiologyInOut : caused by photobiology prider: can't reproduce locally saeSim: can't reproduce locally salem : not sure what the problem is. 🤷 sfnetworks: pull request https://github.com/luukvdmeer/sfnetworks/pull/202 telemac: pull request https://github.com/tpilz/telemac/pull/1 this is about attribute retention of mutate() on things that are not bare data frames.

romainfrancois commented 2 years ago

## New problems (13)

|package                                            |version |error  |warning |note     |
|:--------------------------------------------------|:-------|:------|:-------|:--------|
|[chunked](problems.md#chunked)                     |0.5.1   |__+1__ |        |1 __+1__ |
|[functiondepends](problems.md#functiondepends)     |0.2.1   |       |__+1__  |1        |
|[imfr](problems.md#imfr)                           |0.1.9.1 |__+1__ |        |         |
|[mcp](problems.md#mcp)                             |0.3.1   |__+1__ |        |         |
|[modeltime](problems.md#modeltime)                 |1.1.1   |__+2__ |        |         |
|[NEONiso](problems.md#neoniso)                     |0.5.3   |__+1__ |        |         |
|[photobiology](problems.md#photobiology)           |0.10.8  |__+1__ |__+2__  |         |
|[photobiologyInOut](problems.md#photobiologyinout) |0.4.23  |__+1__ |__+1__  |1        |
|[prider](problems.md#prider)                       |1.0.2   |__+1__ |        |         |
|[saeSim](problems.md#saesim)                       |0.10.0  |__+2__ |__+1__  |__+1__   |
|[salem](problems.md#salem)                         |0.2.0   |       |__+1__  |         |
|[sfnetworks](problems.md#sfnetworks)               |0.5.4   |       |__+1__  |         |
|[telemac](problems.md#telemac)                     |0.1.0   |       |__+1__  |2        |

chunked : pull request https://github.com/edwindj/chunked/pull/21 functiondepends : pull request https://github.com/jakubsob/functiondepends/pull/2 imfr: ~issue https://github.com/christophergandrud/imfr/issues/37~ can't reproduce mcp: issue https://github.com/lindeloev/mcp/issues/140 modeltime: https://github.com/tidyverse/dplyr/pull/6175 NEONiso: https://github.com/tidyverse/dplyr/pull/6175 photobiology: fixed in dev https://github.com/aphalo/photobiology/issues/6 photobiologyInOut : caused by photobiology prider: can't reproduce locally saeSim: can't reproduce locally salem : not sure what the problem is. 🤷 sfnetworks: pull request https://github.com/luukvdmeer/sfnetworks/pull/202 telemac: pull request https://github.com/tpilz/telemac/pull/1 this is about attribute retention of mutate() on things that are not bare data frames.

romainfrancois commented 2 years ago

# Revdeps

## Failed to check (16)

|package        |version |error |warning |note |
|:--------------|:-------|:-----|:-------|:----|
|accept         |?       |      |        |     |
|AgroReg        |1.2.1   |1     |        |     |
|bayesmodels    |?       |      |        |     |
|bsem           |1.0.0   |1     |        |1    |
|CausalImpact   |?       |      |        |     |
|cbar           |?       |      |        |     |
|conos          |1.4.5   |1     |        |     |
|geocmeans      |?       |      |        |     |
|icardaFIGSr    |1.0.2   |1     |        |     |
|loon.ggplot    |?       |      |        |     |
|loon.shiny     |?       |      |        |     |
|MarketMatching |?       |      |        |     |
|MSiP           |1.3.7   |1     |        |     |
|scRNAstat      |0.1.1   |1     |        |     |
|SWMPr          |2.4.1   |1     |        |     |
|vivid          |?       |      |        |     |

## New problems (11)

|package                                            |version |error  |warning |note     |
|:--------------------------------------------------|:-------|:------|:-------|:--------|
|[chunked](problems.md#chunked)                     |0.5.1   |__+1__ |        |1 __+1__ |
|[functiondepends](problems.md#functiondepends)     |0.2.1   |       |__+1__  |1        |
|[mcp](problems.md#mcp)                             |0.3.1   |__+1__ |        |         |
|[nomisr](problems.md#nomisr)                       |0.4.4   |       |__+1__  |         |
|[photobiology](problems.md#photobiology)           |0.10.8  |__+1__ |__+2__  |         |
|[photobiologyInOut](problems.md#photobiologyinout) |0.4.23  |__+1__ |__+1__  |1        |
|[prider](problems.md#prider)                       |1.0.2   |__+1__ |        |         |
|[saeSim](problems.md#saesim)                       |0.10.0  |__+2__ |__+1__  |__+1__   |
|[salem](problems.md#salem)                         |0.2.0   |       |__+1__  |         |
|[sfnetworks](problems.md#sfnetworks)               |0.5.4   |       |__+1__  |         |
|[telemac](problems.md#telemac)                     |0.1.0   |       |__+1__  |2        |

romainfrancois commented 2 years ago

Findings from cran pretests:

chunked : pull request available: https://github.com/edwindj/chunked/pull/21 functiondepends: pull request available: https://github.com/jakubsob/functiondepends/pull/2 imfr: appears to be a connection issues, unrelated to our changes mapping: unrelated to dplyr changes mcp: known issue: https://github.com/lindeloev/mcp/issues/140 prider: fixed in their dev version saeSim: pull request https://github.com/wahani/saeSim/pull/41 sfnetworks: pull request: https://github.com/luukvdmeer/sfnetworks/pull/202 telemac: pull request https://github.com/tpilz/telemac/pull/1